Skip to content

Removes legacy pipelines code from kibana core_plugin#9321

Closed
BigFunger wants to merge 1 commit intoelastic:masterfrom
BigFunger:remove-legacy-pipelines-code
Closed

Removes legacy pipelines code from kibana core_plugin#9321
BigFunger wants to merge 1 commit intoelastic:masterfrom
BigFunger:remove-legacy-pipelines-code

Conversation

@BigFunger
Copy link
Copy Markdown
Contributor

Closes #9320

Removes legacy Pipelines code from core kibana

@ycombinator ycombinator self-assigned this Dec 2, 2016
@w33ble w33ble self-assigned this Dec 2, 2016
@ycombinator
Copy link
Copy Markdown
Contributor

I checked out this PR and clicked around the UI to make sure nothing broke. Nothing broke :)

LGTM.

@ycombinator
Copy link
Copy Markdown
Contributor

jenkins, test this.

@ycombinator
Copy link
Copy Markdown
Contributor

@BigFunger Any ideas why the CI is failing this test?

>> FAIL: ingest API - simulate - should return 400 for an invalid payload (55ms)
Error: expected 400 "Bad Request", got 404 "Not Found"
  at Test._assertStatus  <node_modules/supertest/lib/test.js:232:12>
  at Test._assertFunction  <node_modules/supertest/lib/test.js:247:11>
  at Test.assert  <node_modules/supertest/lib/test.js:148:18>
  at assert  <node_modules/supertest/lib/test.js:127:12>
  at <node_modules/supertest/lib/test.js:124:5>
  at Test.Request.callback  <node_modules/superagent/lib/node/index.js:703:3>
  at Stream.<anonymous>  <node_modules/superagent/lib/node/index.js:922:12>
  at emitNone  <events.js:91:20>
  at Stream.emit  <events.js:185:7>
  at Unzip.<anonymous>  <node_modules/superagent/lib/node/utils.js:108:12>
  at emitNone  <events.js:91:20>
  at Unzip.emit  <events.js:185:7>
  at endReadableNT  <_stream_readable.js:974:12>
  at _combinedTickCallback  <internal/process/next_tick.js:74:11>
  at process._tickCallback  <internal/process/next_tick.js:98:9>

@w33ble
Copy link
Copy Markdown
Contributor

w33ble commented Dec 6, 2016

Gave this a go, everything still looks like it works. There's a bunch of ingest tests that I think you need to remove, but otherwise, this looks fine.

@BigFunger BigFunger closed this Dec 7, 2016
@BigFunger BigFunger reopened this Dec 7, 2016
@BigFunger BigFunger closed this Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants