Change internal document type to push "_doc" instead of "doc"#10533
Closed
robbavey wants to merge 1 commit intoelastic:masterfrom
Closed
Change internal document type to push "_doc" instead of "doc"#10533robbavey wants to merge 1 commit intoelastic:masterfrom
robbavey wants to merge 1 commit intoelastic:masterfrom
Conversation
This commit fixes x-pack integration tests that were broken by elastic/elasticsearch#39888 removing the "doc" type, and using `_doc` in templates.
robbavey
force-pushed
the
xpack_build_3_11
branch
from
c8514ff to
391ed8f
Compare
Member
|
LGTM. At first I was concerned that we're only having to change it in a test-helper function, but an audit of the specs that use this reveals that they're all integration-style tests that verify the effect of loading said pipelines from ES, so we must not be specifying the type on retrieval. |
Member
Author
|
Rob Bavey merged this into the following branches!
|
|
Rob Bavey merged this into the following branches!
|
elasticsearch-bot
pushed a commit
that referenced
this pull request
Mar 11, 2019
This commit fixes x-pack integration tests that were broken by elastic/elasticsearch#39888 removing the "doc" type, and using `_doc` in templates. Fixes #10533
|
Rob Bavey merged this into the following branches!
|
elasticsearch-bot
pushed a commit
that referenced
this pull request
Mar 11, 2019
This commit fixes x-pack integration tests that were broken by elastic/elasticsearch#39888 removing the "doc" type, and using `_doc` in templates. Fixes #10533
Contributor
It was, sorry for the noise, and thanks for the fix Rob ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elastic/elasticsearch#39888 removed the "doc"
type from internal indices, causing breakage in the x-pack integration
tests. This commit changes the type to "_doc" for consistency.