Skip to content

clean up field-reference-parser#12466

Merged
kaisecheng merged 2 commits intoelastic:masterfrom
kaisecheng:remove-field-reference-parser
Nov 24, 2020
Merged

clean up field-reference-parser#12466
kaisecheng merged 2 commits intoelastic:masterfrom
kaisecheng:remove-field-reference-parser

Conversation

@kaisecheng
Copy link
Copy Markdown
Contributor

Fixed: #12355

remove field-reference-parser for version 8

@elasticsearch-bot elasticsearch-bot self-assigned this Nov 24, 2020
@andsel andsel self-requested a review November 24, 2020 14:35
@andsel andsel assigned andsel and unassigned elasticsearch-bot Nov 24, 2020
Copy link
Copy Markdown
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaisecheng kaisecheng merged commit 69451e5 into elastic:master Nov 24, 2020
//NOTE: The notable-breaking-changes tagged regions are re-used in the
//Installation and Upgrade Guide

[[breaking-8.0]]
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karenzone I should cc you before merging it 😨
Could you review the doc? This PR is a breaking change of removing --field-reference-parser

@kaisecheng kaisecheng requested a review from karenzone November 25, 2020 10:58
Copy link
Copy Markdown
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I offered some minor wording changes in line for your consideration.

What you have does not break the build, and will be acceptable for now if you choose not to make the changes now.

The Field Reference parser by default was STRICT in version 7. This configuration is removed permanently.
Logstash keeps the behaviour as if the default setting, which interprets references to fields in your pipelines and plugins,
and rejects inputs that are either ambiguous or illegal.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about:
"The Field Reference parser interprets references to fields in your pipelines and
plugins. It was configurable in 7.x, with the default set to strict to reject
inputs that are ambiguous or illegal. Configurability is removed in 8.0. Now
{ls] rejects ambiguous and illegal inputs as standard behavior."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove "field-reference-parser" setting

4 participants