Adds a required type tag to the open API spec of Logstash APIs.#18169
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label. Could you fix it @mashhurs? 🙏
|
|
@karenzone Can you please 🙏 assign this to someone who is familiar with open API specs in docs team. Thank you! |
| # - $ref: "#/components/schemas/Common" | ||
| # - $ref: '#/components/schemas/PipelineSettings' | ||
| - $ref: "#/components/schemas/PipelinesStats" | ||
| type: object |
There was a problem hiding this comment.
It isn’t required to set the type under schema. Since PipelinesStats is defined as type: object, the allOf will already produce an object type. This section passed the Swagger editor check. Are you encountering any issues?
There was a problem hiding this comment.
Ah, I have zero knowledge about this domain here. The issue says discriminator: "type" must be required. As my understanding, it is about queue.type of the PipelineQueueStats. Since it always present (memory or persisted), I am going to add required.
I have updated the PR with this commit
|
@lcawl FYI. Take a look, please? |
My this comment would be helpful to clarify suggested option B) |
lcawl
left a comment
There was a problem hiding this comment.
Thanks, that addresses the linting error.
Release notes
[rn:skip]
What does this PR do?
Adds required
typefor open API spec in logstash-yaml.Why is it important/What is the impact to the user?
N.A
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs