Skip to content

Adds a required type tag to the open API spec of Logstash APIs.#18169

Merged
mashhurs merged 2 commits intoelastic:mainfrom
mashhurs:add-required-type-in-open-api-specification
Sep 17, 2025
Merged

Adds a required type tag to the open API spec of Logstash APIs.#18169
mashhurs merged 2 commits intoelastic:mainfrom
mashhurs:add-required-type-in-open-api-specification

Conversation

@mashhurs
Copy link
Copy Markdown
Contributor

Release notes

[rn:skip]

What does this PR do?

Adds required type for open API spec in logstash-yaml.

Why is it important/What is the impact to the user?

N.A

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 15, 2025

This pull request does not have a backport label. Could you fix it @mashhurs? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@mashhurs mashhurs added the backport-skip Skip automated backport with mergify label Sep 15, 2025
@mashhurs
Copy link
Copy Markdown
Contributor Author

@karenzone Can you please 🙏 assign this to someone who is familiar with open API specs in docs team. Thank you!

@mashhurs mashhurs self-assigned this Sep 16, 2025
# - $ref: "#/components/schemas/Common"
# - $ref: '#/components/schemas/PipelineSettings'
- $ref: "#/components/schemas/PipelinesStats"
type: object
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn’t required to set the type under schema. Since PipelinesStats is defined as type: object, the allOf will already produce an object type. This section passed the Swagger editor check. Are you encountering any issues?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I have zero knowledge about this domain here. The issue says discriminator: "type" must be required. As my understanding, it is about queue.type of the PipelineQueueStats. Since it always present (memory or persisted), I am going to add required.
I have updated the PR with this commit

@karenzone karenzone requested a review from lcawl September 17, 2025 18:48
@karenzone
Copy link
Copy Markdown
Contributor

@lcawl FYI. Take a look, please?

@mashhurs
Copy link
Copy Markdown
Contributor Author

@lcawl FYI. Take a look, please?

My this comment would be helpful to clarify suggested option B)

Copy link
Copy Markdown
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that addresses the linting error.

@mashhurs mashhurs merged commit 08db1d1 into elastic:main Sep 17, 2025
11 checks passed
@mashhurs mashhurs deleted the add-required-type-in-open-api-specification branch September 17, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Skip automated backport with mergify docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS] OpenAPI discriminator error

4 participants