Merged
Conversation
pquentin
approved these changes
Aug 29, 2023
Member
pquentin
left a comment
There was a problem hiding this comment.
Thanks! I've left optional suggestions.
| return run_command_with_output(f'git -C {repo} rev-parse HEAD').strip() | ||
| else: | ||
| return current.split()[1] | ||
| return current.split()[1].strip() |
Member
There was a problem hiding this comment.
This strip() is not needed as branches was split over "\n" already. But I'm happy to be over-resilient here.
Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can test this PR yourself (prior to elastic/rally#1772 being merged) by applying this patch to your local rally-tracks checkout:
And using this invocation:
Relates elastic/rally#1772