Skip to content

Many shards snapshots challenge for elastic/logs#294

Merged
dliappis merged 4 commits intoelastic:masterfrom
dliappis:many-shards-snapshots
Aug 16, 2022
Merged

Many shards snapshots challenge for elastic/logs#294
dliappis merged 4 commits intoelastic:masterfrom
dliappis:many-shards-snapshots

Conversation

@dliappis
Copy link
Copy Markdown
Contributor

This commit adds a new challenge for many-shards that benchmarks ES
performance while taking several (specified by the track parameter
snapshot_counts) snapshots.

The intention is to initially use it for tracking regressions by
visualizing the service_time of the wait-for-snapshots task.

This PR depends uses the Rally operation
wait-current-snapshots-create operation (introduced in
elastic/rally#1542).

This commit adds a new challenge for many-shards that benchmarks ES
performance while taking several (specified by the track parameter
`snapshot_counts`) snapshots.

The intention is to initially use it for tracking regressions by
visualizing the `service_time` of the `wait-for-snapshots` task.

This PR depends uses the Rally operation
`wait-current-snapshots-create` operation (introduced in
elastic/rally#1542).
@dliappis dliappis added the new workload Any work related to adding a new track or functionality within a track label Aug 10, 2022
@dliappis dliappis self-assigned this Aug 10, 2022
@dliappis dliappis marked this pull request as ready for review August 12, 2022 10:38
@dliappis dliappis requested a review from pquentin August 12, 2022 10:38
Copy link
Copy Markdown
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

"clients": {{ p_bulk_indexing_clients }}
},
{
"name": "register-snapshot-repository",
Copy link
Copy Markdown
Member

@pquentin pquentin Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that no existing track uses Rally's delete-snapshot-repository operation, any idea why? I guess it would be more robust for local execution.

I'm mostly asking for the challenge I'm working on, I don't think this should block this pull request!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question. Such an operation would make sense when >1 iterations of the same challenge run within the same use case. Even then, I am not sure that one needs to delete the repository; I was under the impression that if you re-register the same repository with the exact same parameters, it'll just verify the repository (we could test that). This is probably what happens when several sequential restorations happen -- in the form of several experiments including ES stop/starts -- in logging query benchmarks.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think it's only useful if you made a mistake when developing the track and want to start from a clean slate.

@dliappis dliappis merged commit a765d71 into elastic:master Aug 16, 2022
ebadyano added a commit to ebadyano/rally-tracks that referenced this pull request Jul 11, 2023
A few older many shards challenges got replaced with a new one. Updated README to reflect this.
Also adding a few missing challenges and fixing a few typos.

Relates to: elastic#303
Relates to: elastic#294
ebadyano added a commit that referenced this pull request Jul 18, 2023
A few older many shards challenges got replaced with a new one. Updated README to reflect this.
Also adding a few missing challenges and fixing a few typos.

Relates to: #303
Relates to: #294
inqueue pushed a commit to inqueue/rally-tracks that referenced this pull request Dec 6, 2023
A few older many shards challenges got replaced with a new one. Updated README to reflect this.
Also adding a few missing challenges and fixing a few typos.

Relates to: elastic#303
Relates to: elastic#294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new workload Any work related to adding a new track or functionality within a track

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants