Skip to content

Unblock elastic/logs for public serverless#504

Merged
gbanasiak merged 2 commits intoelastic:masterfrom
gbanasiak:serverless-elastic/logs
Nov 6, 2023
Merged

Unblock elastic/logs for public serverless#504
gbanasiak merged 2 commits intoelastic:masterfrom
gbanasiak:serverless-elastic/logs

Conversation

@gbanasiak
Copy link
Copy Markdown
Contributor

@gbanasiak gbanasiak commented Oct 31, 2023

Similar to #465.

Remarks:

  • unblocking limited to logging-indexing, logging-querying and logging-indexing-querying challenges which are applicable to serverless today,
  • shared custom index settings moved to a dedicated component template (track-custom-shared-settings) to avoid repetition, this makes @custom templates empty, but these are kept as placeholders for any future changes,
  • there is no explicit force merge step in elastic/logs so optional post-ingest sleep was not introduced,
  • compression-statistics custom runner had to be excluded at the track level as it is based on index stats.

Tests:

TRACK=elastic/logs
esrally race --track-path=../rally-tracks/$TRACK --target-hosts=${ES_HOST}:443 --pipeline=benchmark-only --client-options="use_ssl:true,api_key:${ES_API_KEY}" --on-error=abort --challenge="logging-indexing" --test-mode --track-params="start_date:2021-01-01T00-00-00Z,end_date:2021-01-01T00-10-00Z"
esrally race --track-path=../rally-tracks/$TRACK --target-hosts=${ES_HOST}:443 --pipeline=benchmark-only --client-options="use_ssl:true,api_key:${ES_API_KEY}" --on-error=abort --challenge="logging-indexing" --test-mode --track-params="start_date:2021-01-01T00-00-00Z,end_date:2021-01-01T00-10-00Z,refresh_interval:17s"
esrally race --track-path=../rally-tracks/$TRACK --target-hosts=${ES_HOST}:443 --pipeline=benchmark-only --client-options="use_ssl:true,api_key:${ES_API_KEY}" --on-error=abort --challenge="logging-querying" --test-mode --exclude-tasks="tag:setup" --track-params="query_warmup_time_period:1,query_time_period:1,workflow_time_interval:1,think_time_interval:1"
esrally race --track-path=../rally-tracks/$TRACK --target-hosts=${ES_HOST}:443 --pipeline=benchmark-only --client-options="use_ssl:true,api_key:${ES_API_KEY}" --on-error=abort --challenge="logging-indexing-querying" --test-mode --track-params="start_date:2021-01-01T00-00-00Z,end_date:2021-01-01T00-10-00Z,query_warmup_time_period:1,query_time_period:1,workflow_time_interval:1,think_time_interval:1"

Copy link
Copy Markdown
Member

@gareth-ellis gareth-ellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@inqueue inqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@gbanasiak gbanasiak force-pushed the serverless-elastic/logs branch from 773c61d to d551f8b Compare November 2, 2023 20:10
@gbanasiak gbanasiak merged commit 5422b21 into elastic:master Nov 6, 2023
@gbanasiak gbanasiak deleted the serverless-elastic/logs branch November 6, 2023 10:55
inqueue pushed a commit to inqueue/rally-tracks that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants