Use new logo on GitHub, PyPI and Read the Docs#1535
Merged
pquentin merged 2 commits intoelastic:masterfrom Jul 4, 2022
Merged
Conversation
Contributor
|
I think this looks really nice and would be fine with making this change. Not sure if you want additional feedback first, but consider me +1. |
pquentin
changed the title
pquentin
requested review from
DJRickyB,
b-deam,
danielmitterdorfer,
dliappis,
inqueue and
michaelbaamonde
Member
Author
|
I repurposed this pull request to include GitHub and PyPI in addition to docs and would like to know what you think. |
michaelbaamonde
approved these changes
Jun 30, 2022
Contributor
michaelbaamonde
left a comment
michaelbaamonde
left a comment
There was a problem hiding this comment.
Still a fan of this. I'm good with converting the README to Markdown, too.
inqueue
approved these changes
Jun 30, 2022
Member
inqueue
left a comment
inqueue
left a comment
There was a problem hiding this comment.
It looks great, thank you for getting it done!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I repurposed this pull request to include GitHub and PyPI, not only the docs:
You can see live versions at the following URLs:
GitHub
https://github.com/pquentin/rally/tree/readme-logo
PyPI
https://test.pypi.org/project/esrally/2.5.1.dev1/
Read the Docs
https://esrally--1535.org.readthedocs.build/en/1535/