Skip to content

Don't load libs path if not using it#1540

Merged
DJRickyB merged 8 commits intoelastic:masterfrom
DJRickyB:libs-fix
Jul 13, 2022
Merged

Don't load libs path if not using it#1540
DJRickyB merged 8 commits intoelastic:masterfrom
DJRickyB:libs-fix

Conversation

@DJRickyB
Copy link
Copy Markdown
Contributor

@DJRickyB DJRickyB commented Jul 7, 2022

This PR fixes an issue where a dependency installed via the Track Dependencies mechanism lingers for esrally invocations where it is not needed or wanted. Also fixes #1474

@DJRickyB DJRickyB requested a review from cavokz July 13, 2022 15:04
@DJRickyB DJRickyB requested a review from inqueue July 13, 2022 15:43
Copy link
Copy Markdown
Member

@inqueue inqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Copy Markdown
Contributor

@michaelbaamonde michaelbaamonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Solved the issue for me.

@DJRickyB DJRickyB merged commit 20f7600 into elastic:master Jul 13, 2022
@DJRickyB DJRickyB deleted the libs-fix branch July 13, 2022 17:24
@pquentin pquentin added this to the 2.7.0 milestone Nov 2, 2022
@pquentin pquentin added the bug Something's wrong label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something's wrong

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Track code imports can fail due to deferred dependency install

4 participants