Merged
Conversation
inqueue
approved these changes
Jul 11, 2022
Member
inqueue
left a comment
inqueue
left a comment
There was a problem hiding this comment.
Strange this was missed in CI prior to merging. LGTM
Contributor
|
Merging as this is causing CI failures |
Member
|
Sorry! I forgot to ask elasticmachine to run tests, which is required for external contributions. To prevent this in the future I've asked GitHub to require those checks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why CI missed this via
make precommitprior to being merged, but #1541 had two incorrectly formatted files (according to Black).