Skip to content

Run lint with pre-commit#1546

Merged
pquentin merged 7 commits intoelastic:masterfrom
pquentin:precommit
Aug 22, 2022
Merged

Run lint with pre-commit#1546
pquentin merged 7 commits intoelastic:masterfrom
pquentin:precommit

Conversation

@pquentin
Copy link
Copy Markdown
Member

@pquentin pquentin commented Jul 25, 2022

pre-commit is faster because it only applies to modified files and runs in parallel. It's also more convenient because it runs on commits, which ensures you don't forget lint.

@pquentin pquentin added the cleanup Linter changes, reformatting, removal of unused code etc. label Jul 25, 2022
@pquentin pquentin added this to the 2.6.1 milestone Jul 25, 2022
@pquentin pquentin self-assigned this Jul 25, 2022
@pquentin pquentin changed the title Run lint with precommit Run lint with pre-commit Jul 27, 2022
Copy link
Copy Markdown
Contributor

@michaelbaamonde michaelbaamonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool. Worked well for me locally. Thanks!

@pquentin pquentin merged commit d5d79ae into elastic:master Aug 22, 2022
@pquentin pquentin added the :misc Changes that don't affect users directly: linter fixes, test improvements, etc. label Nov 2, 2022
@pquentin pquentin deleted the precommit branch February 16, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Linter changes, reformatting, removal of unused code etc. :misc Changes that don't affect users directly: linter fixes, test improvements, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants