Link to the 7.14.0 ES Python client docs.#1554
Link to the 7.14.0 ES Python client docs.#1554michaelbaamonde merged 3 commits intoelastic:masterfrom
Conversation
This is the version that Rally depends on, so pointing users elsewhere could be misleading.
|
@elasticmachine run tests please |
|
Test failures appear to be due to a network error when attempting to build the Docker image. |
|
@elasticmachine run tests please |
1 similar comment
|
@elasticmachine run tests please |
dliappis
left a comment
dliappis
left a comment
There was a problem hiding this comment.
Good catch. Left a comment that could help reduce maintenance burden in the future.
docs/command_line_reference.rst
Outdated
| With this option you can customize Rally's internal Elasticsearch client. | ||
|
|
||
| It accepts a list of comma-separated key-value pairs. The key-value pairs have to be delimited by a colon. These options are passed directly to the Elasticsearch Python client API. See `their documentation on a list of supported options <http://elasticsearch-py.readthedocs.io/en/master/api.html#elasticsearch.Elasticsearch>`_. | ||
| It accepts a list of comma-separated key-value pairs. The key-value pairs have to be delimited by a colon. These options are passed directly to the Elasticsearch Python client API. See `their documentation on a list of supported options <https://elasticsearch-py.readthedocs.io/en/v7.14.0/api.html#elasticsearch>`_. |
There was a problem hiding this comment.
For the sake of not having to remember changing the version here when we upgrade elasticsearch[async] could we leverage a variable, similar to how we do for MIN_PY_VER? This is achieved with real python code on docs/conf.py so we could determine the version programmatically.
There was a problem hiding this comment.
Perfect, didn't even occur to me. I'll do that.
|
@elasticmachine run tests please |
DJRickyB
left a comment
DJRickyB
left a comment
There was a problem hiding this comment.
LGTM. You may need to forcibly merge given the checks have changed while this has been open; no need of further review from me on that
5 participants
This is the version that Rally depends on, so pointing users elsewhere could be misleading.