Merged
Conversation
DJRickyB
approved these changes
Aug 9, 2022
Contributor
DJRickyB
left a comment
DJRickyB
left a comment
There was a problem hiding this comment.
LGTM. working in both an existing and fresh venv
dliappis
approved these changes
Aug 9, 2022
Contributor
dliappis
left a comment
dliappis
left a comment
There was a problem hiding this comment.
LGTM. Good to see that we don't rely on setuptools anymore.
Member
Author
We still rely on setuptools right now, but it's installed by pip itself and encoded in a single place (pyproject.toml). |
Contributor
Ah yes thanks for the clarification, I forgot the previous PR https://github.com/elastic/rally/pull/1548/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply having a pyproject.toml file with a build-system entry as done in #1548 means that
--no-use-pep517is going to fail. This pull request integrates the relevant part of #1551 to stop doing that.We need to merge this before the nightly benchmarks run.