Fix supplier tests for aarch64#1586
Merged
Merged
Conversation
pquentin
approved these changes
Sep 27, 2022
Member
pquentin
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me!
I find it sad that Elasticsearch forces us to have so many conditions just because x64 is the default arch and is left out from the build command and generated tarball. Well, that's the way it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
TemplateRenderer.archdefaults to the arch of the systeminvoking the tests, when invoked on an aarch64 system, the various
Carinstances would throw exceptions 1 because they weremissing the architecture specific build commands added in
elastic/rally-teams#75
This commit fixes the existing tests to default to
x86_64,and adds two new
aarch64tests.Footnotes
(e.g.
esrally.exceptions.SystemSetupError: Car "default" requires config key "system.build_command.arch") ↩