Skip to content

Add shard data to search operation's detailed-results meta-data#1619

Merged
b-deam merged 2 commits intoelastic:masterfrom
b-deam:search-shards-meta-data
Nov 20, 2022
Merged

Add shard data to search operation's detailed-results meta-data#1619
b-deam merged 2 commits intoelastic:masterfrom
b-deam:search-shards-meta-data

Conversation

@b-deam
Copy link
Copy Markdown
Member

@b-deam b-deam commented Nov 15, 2022

With this commit we include the shard meta-data from Elasticsearch's
search API response when specifying detailed-results for Rally's search
operation.

@b-deam b-deam added the enhancement Improves the status quo label Nov 15, 2022
@b-deam b-deam self-assigned this Nov 15, 2022
michaelbaamonde
michaelbaamonde reviewed Nov 15, 2022
View reviewed changes
michaelbaamonde
michaelbaamonde approved these changes Nov 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@michaelbaamonde michaelbaamonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@b-deam
Copy link
Copy Markdown
Member Author

b-deam commented Nov 17, 2022 •
edited
Loading

@elasticmachine run rally/it-python310

@b-deam
Copy link
Copy Markdown
Member Author

b-deam commented Nov 17, 2022

@elasticmachine run rally/rally-tracks-compat

@b-deam
Copy link
Copy Markdown
Member Author

b-deam commented Nov 17, 2022

I think the rally-track-compat failure is unrelated, it's for .rally/benchmarks/tracks/rally-tracks-compat/it/test_security.py:

12:19:02 ----------------------------- Captured stdout call -----------------------------
12:19:02 
12:19:02     ____        ____
12:19:02    / __ \____ _/ / /_  __
12:19:02   / /_/ / __ `/ / / / / /
12:19:02  / _, _/ /_/ / / / /_/ /
12:19:02 /_/ |_|\__,_/_/_/\__, /
12:19:02                 /____/
12:19:02 
12:19:02 [INFO] Race id is [e931dacd-b0de-47fa-b156-799ebe31503d]
12:19:02 [ERROR] Cannot race. Error in load generator [0]
12:19:02 	No module named 'yaml'

DJRickyB
DJRickyB approved these changes Nov 17, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@DJRickyB DJRickyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@b-deam b-deam added this to the 2.7.1 milestone Nov 17, 2022
@b-deam b-deam merged commit f29a7bd into elastic:master Nov 20, 2022
@b-deam b-deam mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pquentin pquentin Awaiting requested review from pquentin

2 more reviewers

@DJRickyB DJRickyB DJRickyB approved these changes

@michaelbaamonde michaelbaamonde michaelbaamonde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@b-deam b-deam

Labels

enhancement Improves the status quo

Projects

None yet

Milestone

2.7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@b-deam @DJRickyB @michaelbaamonde