Fix broken links on the command line reference docs#1648
Merged
inqueue merged 4 commits intoelastic:masterfrom Jan 18, 2023
Merged
Fix broken links on the command line reference docs#1648inqueue merged 4 commits intoelastic:masterfrom
inqueue merged 4 commits intoelastic:masterfrom
Conversation
DJRickyB
previously requested changes
Jan 5, 2023
Contributor
DJRickyB
left a comment
DJRickyB
left a comment
There was a problem hiding this comment.
I think the same original docs are still intact, at the linked locations
Co-authored-by: Rick Boyd <boyd.richardj@gmail.com>
pquentin
approved these changes
Jan 16, 2023
Member
pquentin
left a comment
pquentin
left a comment
There was a problem hiding this comment.
Thanks! LGTM.
Have you considered linking to https://www.elastic.co/guide/en/elasticsearch/reference/current/important-settings.html#initial_master_nodes for initial_master_nodes? It gives more details.
Member
|
@elasticmachine run rally/it-python38 please |
Member
Author
This makes sense. I linked both seed hosts and initial master nodes to important settings for consistency. |
pquentin
approved these changes
Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken links pointing to the Elasticsearch documentation on the Rally Command Line Reference page.