Propagate request start/end lazily#1687
Merged
danielmitterdorfer merged 2 commits intoelastic:masterfrom Apr 17, 2023
Merged
Conversation
With this commit we only propagate request start and end time to the parent context if there actually is one. Previously we unconditionally propagated the request context which could lead to misleading errors when there was an open request context but no request was issued. This can happen when a mandatory parameter is missing and the runner was throwing exception. That exception would get masked by a `KeyError` because no request start was present yet and thus obfuscate the root cause.
danielmitterdorfer
added
bug
pquentin
approved these changes
Apr 17, 2023
Member
pquentin
left a comment
pquentin
left a comment
There was a problem hiding this comment.
Awesome, this should really help with debugging errors!
Member
Author
|
Thanks for the review Quentin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this commit we only propagate request start and end time to the parent context if there actually is one. Previously we unconditionally propagated the request context which could lead to misleading errors when there was an open request context but no request was issued. This can happen when a mandatory parameter is missing and the runner was throwing exception. That exception would get masked by a
KeyErrorbecause no request start was present yet and thus obfuscate the root cause.