Skip to content

Ignore HTTP 404 consistently in runners#1691

Merged
danielmitterdorfer merged 3 commits intoelastic:masterfrom
danielmitterdorfer:consistent-ignore
Mar 30, 2023
Merged

Ignore HTTP 404 consistently in runners#1691
danielmitterdorfer merged 3 commits intoelastic:masterfrom
danielmitterdorfer:consistent-ignore

Conversation

@danielmitterdorfer
Copy link
Copy Markdown
Member

Some runners that deleted resources have ignored HTTP 404 already but we did not apply this consistently. With this commit, all runners that delete resources ignore HTTP 404 to avoid spurious request errors.

Some runners that deleted resources have ignored HTTP 404 already but we
did not apply this consistently. With this commit, all runners that
delete resources ignore HTTP 404 to avoid spurious request errors.
@danielmitterdorfer danielmitterdorfer added bug Something's wrong :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. labels Mar 24, 2023
@danielmitterdorfer danielmitterdorfer added this to the 2.8.0 milestone Mar 24, 2023
@danielmitterdorfer danielmitterdorfer self-assigned this Mar 24, 2023
Copy link
Copy Markdown
Member

@b-deam b-deam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. LGTM.

Note to self that this'll all have to be refactored as part of #1673 anyway

@danielmitterdorfer danielmitterdorfer merged commit 53f6cc5 into elastic:master Mar 30, 2023
@danielmitterdorfer danielmitterdorfer deleted the consistent-ignore branch March 30, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something's wrong :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants