Update progress after GCS download finished#1698
Merged
danielmitterdorfer merged 1 commit intoelastic:masterfrom Apr 3, 2023
Merged
Update progress after GCS download finished#1698danielmitterdorfer merged 1 commit intoelastic:masterfrom
danielmitterdorfer merged 1 commit intoelastic:masterfrom
Conversation
With this commit we ensure that the progress indicator is updated once again after a download from a GCS bucket has finished.
danielmitterdorfer
added
bug
Member
Author
|
I noticed this because on a new track that I've created I always saw this after the track data have been downloaded and I was puzzled why it wouldn't say 100%. With this change: |
dliappis
approved these changes
Mar 31, 2023
Contributor
dliappis
left a comment
dliappis
left a comment
There was a problem hiding this comment.
LGTM thanks for catching this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this commit we ensure that the progress indicator is updated once again after a download from a GCS bucket has finished.