Refactor some runners to set transport level options#1705
Merged
dliappis merged 1 commit intoelastic:masterfrom Apr 19, 2023
Merged
Refactor some runners to set transport level options#1705dliappis merged 1 commit intoelastic:masterfrom
dliappis merged 1 commit intoelastic:masterfrom
Conversation
…ort level options via 'options()'
dliappis
approved these changes
Apr 18, 2023
Contributor
dliappis
left a comment
dliappis
left a comment
There was a problem hiding this comment.
LGTM from me too, thanks for the quick turnaround.
| if (ignore_status := request_params.pop("ignore", None)) or (ignore_status := params.pop("ignore", None)): | ||
| transport_params["ignore_status"] = ignore_status | ||
|
|
||
| headers = params.pop("headers", None) or {} |
Contributor
There was a problem hiding this comment.
For my own curiosity: there is a possibility that the headers key exists but is not a dict, hence we need to do the or {} instead of just params.pop("headers", {})?
This was referenced Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this commit we fix a bug that prevented any runner using the low
level
perform_request()ES client method, and_transport_request_params()helper method from passing in the
request-timeoutparameter.Relates #1673
Relates elastic/rally-tracks#393
Note that there's still follow up work to be done to refactor the remaining runners, specifically around overriding the client's
options()method to handle thedistribution_versionparam to support REST compatibility headers as discussed in #1673, but that will only affect us when 9.x is released.