Skip to content

Allow specifying branch together with timestamp in revision#1706

Merged
dliappis merged 2 commits intoelastic:masterfrom
dliappis:branch-in-ts
Apr 25, 2023
Merged

Allow specifying branch together with timestamp in revision#1706
dliappis merged 2 commits intoelastic:masterfrom
dliappis:branch-in-ts

Conversation

@dliappis
Copy link
Copy Markdown
Contributor

@dliappis dliappis commented Apr 20, 2023 •
edited
Loading

With this commit, we add support for an optional branch when a timestamp is specified in --revision. This is intended primarily for Elasticsearch nightly benchmarks.

@dliappis
Allow specifying branch together with timestamp in revision
a79c1f1 
With this commit, we add support for an optional branch when a
timestamp is specified in --revision. This is intended primarily for
Elasticsearch nightly benchmarks.
@dliappis dliappis added enhancement Improves the status quo :Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch labels Apr 20, 2023
@dliappis dliappis requested review from b-deam and pquentin April 20, 2023 12:54
@dliappis dliappis self-assigned this Apr 20, 2023
@dliappis dliappis requested a review from csoulios April 20, 2023 12:54
@dliappis
Copy link
Copy Markdown
Contributor Author

dliappis commented Apr 20, 2023

Example invocations:

esrally build --revision=feature-branch@2023-04-19T18:00:00Z

esrally race --track=nyc_taxis --challenge=append-no-conflicts-index-only --revision="8.7@2023-04-19T18:00:00Z" --track-params="ingest_percentage:5" --car=defaults,16gheap --on-error=abort --kill-running-processes

b-deam
b-deam reviewed Apr 21, 2023
View reviewed changes
@dliappis @b-deam
Update docs/command_line_reference.rst
9e1832c 
Co-authored-by: Brad Deam <54515790+b-deam@users.noreply.github.com>
@dliappis dliappis removed the request for review from pquentin April 21, 2023 11:44
@dliappis dliappis merged commit be05b65 into elastic:master Apr 25, 2023
@dliappis dliappis added this to the 2.8.0 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@b-deam b-deam b-deam approved these changes

@csoulios csoulios Awaiting requested review from csoulios

Assignees

@dliappis dliappis

Labels

:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch enhancement Improves the status quo

Projects

None yet

Milestone

2.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dliappis @b-deam