Merged
Conversation
No message with that name exists today.
While the asyncio documentation uses variables named `aws`, I always struggle to remember what that means in the context of Rally.
pquentin
added
cleanup
send -> track_preparation_actor
sender -> task_execution_actor
gareth-ellis
force-pushed
the
actor-system-cleanup
branch
from
7f9403a to
9db918f
Compare
Member
Author
|
Thanks! LGTM. You will have to approve yourself as I can't approve my own pull request. |
gareth-ellis
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the the commits for the details.