Conversation
|
/cc @craigtaverner |
This reverts commit a053ecc.
|
|
||
|
|
||
| class Esql(Runner): | ||
| async def __call__(self, es, params): |
There was a problem hiding this comment.
There are a couple of high level properties that operations should expose, namely:
request-timeoutheadersopaque-id
You can add support for these by using the Runner._transport_request_params helper method:
rally/esrally/driver/runner.py
Lines 210 to 231 in fc7d959
An example of usage:
rally/esrally/driver/runner.py
Line 1971 in fc7d959
b-deam
left a comment
There was a problem hiding this comment.
LGTM. I left one comment about using a helper method around configuring the different request, transport, and header parameters but no need for another review.
|
@b-deam @gbanasiak Thanks for reviews. |
|
@elasticmachine run rally/it-python310 please |
|
|
||
| * ``query`` (mandatory): An ES|QL query starts with a source command followed processing commands. | ||
| * ``filter`` (optional): A query filter defined in `Elasticsearch query DSL <https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl.html>`_. | ||
| * ``body`` (optional): The query body. |
There was a problem hiding this comment.
The description here should indicate that this is used for anything additions to put into the body, since the query will already be placed there. For example, we use this for pragma.
This pull request introduces the ES|QL operator. This operator, for now, supports only two main parameters:
queryandfilter.