Skip to content

Restore time measurement on request end #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gbanasiak merged 2 commits into from
Jun 27, 2024
Merged

Restore time measurement on request end #1861

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b39ba8c
Restore time measurement on request end
gbanasiak Jun 26, 2024
929d4fe
Add comment
gbanasiak Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions esrally/client/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,13 @@ async def on_request_end(session, trace_config_ctx, params):
# Rally's implementation of the `on_request_end` callback handler updates the timestamp on every call, Rally
# will ultimately record the time when it received the *last* chunk. This is what we want because any code
# that is using the Elasticsearch client library can only act on the response once it is fully received.
#
# We also keep registering for `TraceConfig.on_request_end()` instead of relying on
# `TraceConfig.on_response_chunk_received()` only to handle corner cases during client timeout when aiohttp does
# not call request exception handler, but does call request end handler. See
# https://github.com/elastic/rally/issues/1860 for details.
trace_config.on_response_chunk_received.append(on_request_end)
trace_config.on_request_end.append(on_request_end)
# ensure that we also stop the timer when a request "ends" with an exception (e.g. a timeout)
trace_config.on_request_exception.append(on_request_end)

Expand Down