Skip to content

Avoid logging ES credentials from running Rally processes#1863

Merged
inqueue merged 5 commits intoelastic:masterfrom
inqueue:20240627-password-leak
Jul 1, 2024
Merged

Avoid logging ES credentials from running Rally processes#1863
inqueue merged 5 commits intoelastic:masterfrom
inqueue:20240627-password-leak

Conversation

@inqueue
Copy link
Copy Markdown
Member

@inqueue inqueue commented Jun 27, 2024

Replace the basic authentication password and API key with '*****' before creating the log entry when killing a running process.

Support both --client-options CLI formats:

  • name:value pairs
  • inline JSON

Closes #1862

@inqueue inqueue requested a review from gbanasiak June 27, 2024 20:19
@inqueue inqueue marked this pull request as ready for review June 28, 2024 17:44
@gbanasiak gbanasiak added this to the 2.11.1 milestone Jul 1, 2024
Copy link
Copy Markdown
Contributor

@gbanasiak gbanasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. I've fixed incorrect method call after the latest refactor in d5a6508, see f6a3a89.

@gbanasiak gbanasiak added the bug Something's wrong label Jul 1, 2024
@inqueue inqueue merged commit b904c17 into elastic:master Jul 1, 2024
@inqueue inqueue deleted the 20240627-password-leak branch July 1, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something's wrong

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Elasticsearch cluster authentication credentials can leak into rally.log

2 participants