fixes #1881 - composite operation failing when track_total_hits is false#1882
Merged
ugosan merged 15 commits intoelastic:masterfrom Oct 29, 2024
ugosan:master
Merged
fixes #1881 - composite operation failing when track_total_hits is false#1882ugosan merged 15 commits intoelastic:masterfrom ugosan:master
ugosan merged 15 commits intoelastic:masterfrom
ugosan:master
Conversation
…sociated with the async search
commit 5746dc3 Author: Ugo Sangiorgi <ugo.sangiorgi@elastic.co> Date: Fri Oct 18 13:27:44 2024 -0500 checking if total is reported (track_total_hits) commit 6999097 Author: Ugo Sangiorgi <ugo.sangiorgi@elastic.co> Date: Fri Oct 18 13:26:58 2024 -0500 enforcing wait_for_completion_timeout = 0 so there is always an id associated with the async search commit 1086eaf Author: Ugo Sangiorgi <ugo.sangiorgi@elastic.co> Date: Thu Oct 17 11:40:39 2024 -0500 adding True as default for track_total_hits commit 4c68e3a Author: Ugo Sangiorgi <ugo.sangiorgi@elastic.co> Date: Thu Oct 17 11:14:10 2024 -0500 fixes composite operation failing when track_total_hits is false
Co-authored-by: Gareth Ellis <gareth.ellis@elastic.co>
Co-authored-by: Gareth Ellis <gareth.ellis@elastic.co>
Co-authored-by: Gareth Ellis <gareth.ellis@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue (#1881) where a composite operation using async search fails when track_total_hits is set to false in the request. The failure occurs because the response does not include the hits.total field, causing a KeyError during the retrieval of async search results.
Changes:
"wait_for_completion_timeout": 0which defaults to 1 second, causing async searches faster than 1 second to not have an id assigned, which would break thecompositeflow, with submit, get and delete all relying on an id.