Add Jinja filters for creating dynamic date ranges based on now()#1884
Merged
inqueue merged 5 commits intoelastic:masterfrom Oct 24, 2024
Merged
Add Jinja filters for creating dynamic date ranges based on now()#1884inqueue merged 5 commits intoelastic:masterfrom
inqueue merged 5 commits intoelastic:masterfrom
Conversation
martijnvg
reviewed
Oct 23, 2024
Member
martijnvg
left a comment
There was a problem hiding this comment.
This looks great 👍 . I think we can use this in several tracks that use data generation. I would say we also want this for stateful benchmark runs, since it just makes a benchmark more realistic.
* Small corrections to now and days_ago() * Add section on dynamic date ranges for get_start_date() and get_end_date()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In serverless, data is considered hot when document timestamps are within the boost window and cold when timestamps are outside the boost window. Tracks using date ranges for corpus generation are limited to static dates, presenting a problem for nightly benchmarks where all ingested data is indexed cold.
This commit adds two custom Jinja filters to the track loader to create dynamic date ranges. These simple functions are most useful in the serverless context for any track utilizing date ranges for corpus generation. Usage:
get_start_date(format)Pair with the
nowglobal template variable to produce a start date:Result:
get_end_date(duration_days, format)Result:
Documentation
Documentation will be added with a subsequent commit to this PR. The documentation on the
nowglobal filter does not mention the return value is a float as it is the result oftime.time().