Suppress a flaky internal mypy error appearing randomly when executing make lint.#1919
Conversation
90e6e0a to
a03d8b4
Compare
95433b0 to
b110850
Compare
|
@fressi-elastic I've removed |
No the scope is the one in the title. I included other changes by mistake. I am sorry for it. I am going to remove unrelated changes from this one. |
b110850 to
0cac391
Compare
make lint.make lint.
gbanasiak
left a comment
There was a problem hiding this comment.
I assume this makes mypy check slower under pre-commit, but correctness is more important than speed. We can revisit if this becomes too slow for us for some reason.
|
The speed difference are irrelevants with my M4 14 cores MacBook. I also guess that the reason I see so many errors is because I was working with so many fast cores. With less and slower cores probably race conditions are harder to spot. Anyway considering the correctness and reliability of tests is much more important than speed I agree that we should wait the bug is fixed on |
Fixes Rally issue #1918.