feat: Optionally ignore unused track parameters#2077
Open
lhearachel wants to merge 1 commit intoelastic:masterfrom
Open
feat: Optionally ignore unused track parameters#2077lhearachel wants to merge 1 commit intoelastic:masterfrom
lhearachel wants to merge 1 commit intoelastic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to ignore totally-unused track parameters, rather than always failing with an error when a track parameter is given but not used. This is, at minimum, a developer-experience improvement while building new tracks.
Sample Output
Testing
I get the following error when I run
make check-alllocally: