Merged
Conversation
k-yomo
force-pushed
the
add-min-setting-to-rollover
branch
from
417c005 to
1a23ab7
Compare
tobio
reviewed
Jan 17, 2023
Member
tobio
left a comment
tobio
left a comment
There was a problem hiding this comment.
Looks good, adding the version to the field description to be consistent with total_shards_per_node.
internal/elasticsearch/index/ilm.go
Outdated
| Optional: true, | ||
| }, | ||
| "min_age": { | ||
| Description: "Prevents rollover until after the minimum elapsed time from index creation is reached.", |
Member
There was a problem hiding this comment.
Suggested change
| Description: "Prevents rollover until after the minimum elapsed time from index creation is reached.", | |
| Description: "Prevents rollover until after the minimum elapsed time from index creation is reached. Supported from Elasticsearch version **8.4**", |
internal/elasticsearch/index/ilm.go
Outdated
| Optional: true, | ||
| }, | ||
| "min_docs": { | ||
| Description: "Prevents rollover until after the specified minimum number of documents is reached.", |
Member
There was a problem hiding this comment.
Suggested change
| Description: "Prevents rollover until after the specified minimum number of documents is reached.", | |
| Description: "Prevents rollover until after the specified minimum number of documents is reached. Supported from Elasticsearch version **8.4**", |
| Optional: true, | ||
| }, | ||
| "min_size": { | ||
| Description: "Prevents rollover until the index reaches a certain size.", |
Member
There was a problem hiding this comment.
Suggested change
| Description: "Prevents rollover until the index reaches a certain size.", | |
| Description: "Prevents rollover until the index reaches a certain size. Supported from Elasticsearch version **8.4**", |
internal/elasticsearch/index/ilm.go
Outdated
| Optional: true, | ||
| }, | ||
| "min_primary_shard_size": { | ||
| Description: "Prevents rollover until the largest primary shard in the index reaches a certain size.", |
Member
There was a problem hiding this comment.
Suggested change
| Description: "Prevents rollover until the largest primary shard in the index reaches a certain size.", | |
| Description: "Prevents rollover until the largest primary shard in the index reaches a certain size. Supported from Elasticsearch version **8.4**", |
internal/elasticsearch/index/ilm.go
Outdated
| Optional: true, | ||
| }, | ||
| "min_primary_shard_docs": { | ||
| Description: "Prevents rollover until the largest primary shard in the index reaches a certain number of documents.", |
Member
There was a problem hiding this comment.
Suggested change
| Description: "Prevents rollover until the largest primary shard in the index reaches a certain number of documents.", | |
| Description: "Prevents rollover until the largest primary shard in the index reaches a certain number of documents. Supported from Elasticsearch version **8.4**", |
tobio
approved these changes
Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #247
This PR adds
min_*fields to rollover which is released in 8.4.0.https://www.elastic.co/guide/en/elasticsearch/reference/current/ilm-rollover.html