Skip to content

Replace some logical OR by nullish coalescing operators#218

Merged
elchininet merged 1 commit intomasterfrom
fix_0_values
Dec 20, 2024
Merged

Replace some logical OR by nullish coalescing operators#218
elchininet merged 1 commit intomasterfrom
fix_0_values

Conversation

@elchininet
Copy link
Copy Markdown
Owner

Some values were taking their default values using logical OR operators, something that made to take the default value if the assigned value was 0. This pull request replaces those logical OR operators by nullish coalescing ones to avoid this behaviour.

@elchininet elchininet added the bug Something isn't working label Dec 20, 2024
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 20, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling d27f45c on fix_0_values
into f98883c on master.

@elchininet elchininet merged commit 9eaf6c5 into master Dec 20, 2024
@elchininet elchininet deleted the fix_0_values branch December 20, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants