Checksum mismatch on Windows NSIS

[Daymannovaes]

• Version: 10.8.1

• Target: NSIS
  (building from windows too)

• Node version: 6.9.1

• npm version: 4.0.3

I'm getting checksum mismatch, like following in the screenshot

I uploaded the executables with --publish=always at github and didn't change anything.
The fact that I'm checking for updates a lot of times even ater the download starts, can affect this?

Because just for test purpose, I put the check interval to 30 seconds, so I get update-available a bunch of times.

Plus, I'm getting everytime a different checksum. What's going on?

My autoupdater module is very simple:

autoUpdater.addListener('update-available', () => {
  logger.info('update-available');
});
autoUpdater.addListener('update-downloaded', (event, releaseNotes, releaseName, releaseDate, updateURL) => {
  autoUpdater.quitAndInstall();
});
autoUpdater.addListener('error', (error) => {
  logger.error('error when trying to check for update');
  logger.error(error);
});
autoUpdater.addListener('checking-for-update', () => {
  logger.info('checking-for-update');
});
autoUpdater.addListener('update-not-available', () => {
  logger.info('update-not-available');
});

async function setup() {
  autoUpdater.checkForUpdates();

  await sleep(30 * 1000);
  setup();
}
setup();

And but package config is simple too:

"build": {
    "appId": "some-id",
    "files": [
      "node_modules/**/*",
      ".env",
      "app/**/*"
    ],
    "publish": [
      {
        "provider": "github",
        "repo": "some-repo"
      }
    ],
    "win": {
      "certificateFile": "./certs/my_signing_key.pfx",
      "certificatePassword": ""
    }
  }

[develar]

Probably. Confirmed that we don't queue check updates requests. Should be fixed. In any case it is better to check updates not so often.

[tvanro]

electron-builder: 10.16.0
electron-auto-updater: 0.9.0

Target: NSIS
(building from docker on Linux)

I'm receiving the exact same error so there's still something going on I'm afraid.
Like with @Daymannovaes, the second checksum is different on each check from electron-builder. My guess is that it's doing the check on a whole file-download request instead of only the file.

This is my autoUpdater implementation:

autoUpdater.addListener("update-available", function(event) {
  dialog.showMessageBox(mainWindow, {title: "update-available", message: "A new update is available"});
});
autoUpdater.addListener("update-downloaded", function(event, releaseNotes, releaseName, releaseDate, updateURL) {
  dialog.showMessageBox(mainWindow, {title: "A new update is ready to install", message: `Version ${releaseName} is downloaded and will be automatically installed on Quit`});
  autoUpdater.quitAndInstall()
  return true    
});
autoUpdater.addListener("error", function(error) {
  dialog.showMessageBox(mainWindow, {title: "error", message: JSON.stringify(error)});
});
autoUpdater.addListener("checking-for-update", function(event) {
  dialog.showMessageBox(mainWindow, {title: "checking-for-update", message: "Checking for update"});
});
autoUpdater.addListener("update-not-available", function() {
  dialog.showMessageBox(mainWindow, {title: "update-not-available", message: "Update not available"});
});

mainWindow.webContents.once("did-frame-finish-load", function(event) {
  dialog.showMessageBox(mainWindow, {title: "autoUpdater", message: 'checking for updates....'});
  autoUpdater.checkForUpdates();
})

And package.config:

  "build": {
    "appId": ".....",
    "win": {
      "signingHashAlgorithms": "sha256",
      "certificateFile": ".certs/certificate.pfx",
      "certificatePassword": "......"
    },
    "publish": {
      "provider": "generic",
      "url": "....."
    }
  },

[develar]

@tvanro What server do you use? Amazon S3? GitHub? Own server (please at least specify server — nginx, some node module).

[tvanro]

@develar thanks for getting back to me.
I'm using an own server, nginx/1.11.5 to be precise.

[maczikasz]

I see the same issue, with ownserver (spring boot based) but what I also see is that the file that was downloaded is not runnable, @tvanro does that happen to you too?

I wrote a small app that uses electron.net to download a file and pipe it to a file, and what I see that downloading the same file with auto updater results in a file that's 3 KB smaller

If I remove the part where it notifies the "transferred" callback (from the compiled js), it works perfectly

[maczikasz]

Adding response.pause to the compiled js solved the issue for me

[tvanro]

You rock @maczikasz !
I installed electron-auto-updater 0.9.1 and it works as expected now