TypeError when publishing to Github

[benmarch]

• Version: 3.3.0

• Target: Mac

I am getting an error when attempting to publish to a Github repo. This is part of the stack trace (let me know if you need more of it):

TypeError: Cannot read property 'url' of null
    at /Users/ben.march/content-manager/node_modules/electron-builder/src/publish/PublishManager.ts:79:8
    at next (native)
From previous event:
    at PublishManager.packager.addAfterPackHandler (/Users/ben.march/content-manager/node_modules/electron-builder/out/publish/PublishManager.js:273:29)
    at default.each.it (/Users/ben.march/content-manager/node_modules/electron-builder/src/packager.ts:376:49)
From previous event:
    at Packager.afterPack (/Users/ben.march/content-manager/node_modules/electron-builder/src/packager.ts:376:28)
    at /Users/ben.march/content-manager/node_modules/electron-builder/src/platformPackager.ts:231:21
    at next (native)
    at tryOnImmediate (timers.js:543:15)
    at processImmediate [as _immediateCallback] (timers.js:523:5)

and here is my publish config:

"build": {
    "asar": false,
    "appId": "org.******.ContentManager",
    "mac": {
      "publish": [{
        "provider": "github",
        "host": "git.*******.org",
        "repo": "*****/content-manager"
      }],
      "category": "public.app-category.utility"
    },
    "dmg": {
      "title": "Content Manager"
    }
  }

I did some debugging and it appears that publishConfigs === [null], so publishConfig === null which is why it is throwing the TypeError.

Thanks,
Ben

[develar]

Do you use GitHub Enterprise?

[benmarch]

Yes, I saw that you added that feature today and the timing couldn't have been better. I would like try this with hosted GH to rule that out but my company doesn't allow that.

[develar]

Ok, I will add test case (thanks for clear report and provided configs) to investigate.

[benmarch]

Thank you for your quick response!

[benmarch]

To give you a bit more information:

I created a private repo on hosted GH and used the minimum config "publish": [{"provider": "github"}] and that worked.

Then I added the repository field to package.json and it still worked.

Then I added the "repo" option to the publish config and it still worked.

When I changed the repository field in package.json to the GH Enterprise URL (keeping everything else the same) it threw the error.

When I changed the "repo" option to match the GH Enterprise repo it threw the error.

It looks like the repository field takes precedent over the "repo" option, and it has a hard time parsing the GH Enterprise URL.

Hope this helps.

[benmarch]

Hey @develar, I noticed that a few GitHub changes were released a few days ago. Was this included or is it still open?

Thanks,
Ben

[develar]

Some changes were performed, but I haven't yet verified issue.

[rophy]

I'm having this problem as of v13.9.0.

[develar]

Please check 14.4.2.

[benmarch]

Still getting an error with 14.4.2 (and 14.5.0) but it is a different error:

Error: Cannot detect repository by .git/config. Please specify "repository" in the package.json (https://docs.npmjs.com/files/package.json#repository).
Please see https://github.com/electron-userland/electron-builder/wiki/Publishing-Artifacts
    at /Users/*****/node_modules/electron-builder/src/publish/publisher.ts:29:13
    at next (native)

I am using the same config as in the original post, and I have added the repository field to package.json. I tried both the shorthand form "repository": "https://git.****.org/****/content-manager.git" and the longer form:

"repository": {
  "type": "git",
  "url": "https://git.****.org/****/content-manager.git"
}