feat(appimage): If necessary, start with --no-sandbox#9590
Open
sabonerune wants to merge 7 commits intoelectron-userland:masterfrom
Open
feat(appimage): If necessary, start with --no-sandbox#9590sabonerune wants to merge 7 commits intoelectron-userland:masterfrom
--no-sandbox#9590sabonerune wants to merge 7 commits intoelectron-userland:masterfrom
Conversation
🦋 Changeset detectedLatest commit: d3480ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I would suggest changing the pull request title and changelog entry, as it sounds like you are adding the |
mmaietta
requested changes
Feb 15, 2026
| super("appImage") | ||
|
|
||
| this.desktopEntry = new Lazy<string>(() => { | ||
| const args = this.options.executableArgs?.join(" ") || "--no-sandbox" |
Collaborator
There was a problem hiding this comment.
This is a breaking change for appimage toolset 0.0.0 (legacy) as it's AppRun script is hardcoded in upstream dependency app-builder-bin
b752196 to
515c227
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #8440
The method in #4496 has the following drawbacks:
The AppImage can be launched without desktop integration.
It also doesn't work when started from the command line.
user namespace should now be available on many Linux systems.
This means that
--no-sandboxis only needed in limited environments.Even in Ubuntu 24.04 or later, starting from file manager bypasses AppArmor restrictions, so
--no-sandboxis not required.https://discourse.ubuntu.com/t/understanding-apparmor-user-namespace-restriction/58007#p-148026-bypassing-apparmor-security-restriction
It's also possible that the user has disabled AppArmor.
This solves these problems by automatically detecting when the user namespace is unavailable and adding
--no-sandboxat runtime.