Skip to content

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Aug 22, 2025

Content

Add UI components for spaces.

Motivation and context

Prepare work for spaces.

Screenshots / GIFs

See recorded ones.

Tests

  • No expected changes.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner August 22, 2025 13:10
@bmarty bmarty added the PR-Wip For anything that isn't ready to ship and will be enabled at a later date label Aug 22, 2025
@bmarty bmarty requested review from jmartinesp and removed request for a team August 22, 2025 13:10
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/dqiTLT

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I think some Konsist tests need to be fixed before merging.

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 93.97590% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.21%. Comparing base (8245ad8) to head (7b1a4bb).
⚠️ Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
...ndroid/libraries/matrix/impl/room/join/JoinRule.kt 0.00% 1 Missing and 1 partial ⚠️
...oid/libraries/matrix/ui/components/SpaceInfoRow.kt 95.23% 0 Missing and 2 partials ⚠️
.../libraries/matrix/ui/components/SpaceHeaderView.kt 96.96% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5207      +/-   ##
===========================================
+ Coverage    80.19%   80.21%   +0.01%     
===========================================
  Files         2238     2240       +2     
  Lines        61349    61419      +70     
  Branches      7769     7774       +5     
===========================================
+ Hits         49198    49265      +67     
  Misses        9308     9308              
- Partials      2843     2846       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit a625c10 into develop Aug 23, 2025
30 of 31 checks passed
@bmarty bmarty deleted the feature/bma/spaceInfoUi branch August 23, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Wip For anything that isn't ready to ship and will be enabled at a later date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants