Reload member list after moderation actions

[jmartinesp]

Content

• When a moderation action is done (kicking, banning, unbanning), reload the member list instead of trying to modify the member list Flow.
• Ensure the Ready state is set to the flow, even if the LaunchedEffect/collectLatest scope is cancelled.

Motivation and context

The previous runActionAndWaitForMembershipChange logic wasn't really doing anything, as the modified flow was never used. This means kicking, banning or unbanning a user didn't reload the member list consistently.

Tests

In a room you're an admin/moderator:

• Invite a couple of users. The room member list is updated.
• Kick one of them. The list should update.
• Then ban and unban the other. In both cases, the updates should be visible.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pCRGoN

[codecov]

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.21%. Comparing base (83c72f4) to head (5b5f1db).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines	Patch %	Lines
...s/matrix/impl/room/member/RoomMemberListFetcher.kt	66.66%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #5268   +/-   ##
========================================
  Coverage    80.21%   80.21%           
========================================
  Files         2239     2239           
  Lines        61503    61507    +4     
  Branches      7791     7791           
========================================
+ Hits         49333    49337    +4     
  Misses        9314     9314           
  Partials      2856     2856           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bmarty]

LGTM, thanks

[bmarty]

I am not sure to understand the effect of this. It is supposed to close the bottom sheet as soon as an action is selected, to avoid that a bottom sheet is displayed at the same time as a confirmation dialog, but this is already the current behavior. Is there some other rationale?

[jmartinesp]

It is supposed to close the bottom sheet as soon as an action is selected, to avoid that a bottom sheet is displayed at the same time as a confirmation dialog, but this is already the current behavior.

It wasn't after I made these changes, I had to manually set it to an empty list or both the action list and the confirmation dialog would be displayed at the same time.

[jmartinesp]

Oh, it's because the actions were computed for the user I was banning, then I tried to unban that same user, and it was displaying the previously calculated actions, which no longer apply.

[bmarty]

ok, thanks!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud