Skip to content

Conversation

@ganfra
Copy link
Member

@ganfra ganfra commented Oct 6, 2025

Content

This PR introduces 3 changes related to space feature :

  • Makes sure room name from space list is computed locally for DMs (waiting for sdk to handle it)
  • Removes the room counts from the ui as it's not accurate
  • Add "Shared space" label for restricted space/room

Motivation and context

Better space support.

Screenshots / GIFs

Check recorded screenshots.

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ganfra ganfra added Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. PR-Wip For anything that isn't ready to ship and will be enabled at a later date labels Oct 6, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/QjMJir

@ganfra ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 6, 2025
@ganfra ganfra marked this pull request as ready for review October 6, 2025 19:17
@ganfra ganfra requested a review from a team as a code owner October 6, 2025 19:17
@ganfra ganfra requested review from jmartinesp and removed request for a team October 6, 2025 19:17
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 6, 2025
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks (after fixing the tests)!

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

@ganfra ganfra enabled auto-merge October 7, 2025 08:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2025

@ganfra ganfra merged commit a497703 into develop Oct 7, 2025
28 of 29 checks passed
@ganfra ganfra deleted the feature/fga/space_tweaks branch October 7, 2025 08:55
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 95.23810% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.91%. Comparing base (68700d9) to head (adb4828).
⚠️ Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
...ibraries/matrix/ui/components/SpaceRoomItemView.kt 88.88% 1 Missing and 1 partial ⚠️
...t/android/libraries/matrix/api/spaces/SpaceRoom.kt 85.71% 0 Missing and 1 partial ⚠️
...libraries/matrix/api/spaces/SpaceRoomVisibility.kt 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5468   +/-   ##
========================================
  Coverage    81.90%   81.91%           
========================================
  Files         2362     2363    +1     
  Lines        67022    67040   +18     
  Branches      8096     8100    +4     
========================================
+ Hits         54896    54915   +19     
+ Misses        9160     9159    -1     
  Partials      2966     2966           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Wip For anything that isn't ready to ship and will be enabled at a later date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants