Skip to content

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Oct 16, 2025

Content

2 commits:

  • Extract console message logger in order to use it at different places.
  • Mutualize instance of Json, it's good for performance.

Motivation and context

Avoid code duplication and share instances.

Screenshots / GIFs

No expected change.

Tests

No expected regression

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty added the PR-Misc For other changes label Oct 16, 2025
@bmarty bmarty marked this pull request as ready for review October 16, 2025 14:39
@bmarty bmarty requested a review from a team as a code owner October 16, 2025 14:39
@bmarty bmarty requested review from ganfra and removed request for a team October 16, 2025 14:39
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Eu54dC

@bmarty bmarty enabled auto-merge October 16, 2025 16:17
@sonarqubecloud
Copy link

@bmarty bmarty merged commit a264654 into develop Oct 16, 2025
29 of 30 checks passed
@bmarty bmarty deleted the feature/bma/extractConsoleMessageLogger branch October 16, 2025 16:46
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 27.65957% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.84%. Comparing base (5702b38) to head (b01de9e).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...aries/androidutils/browser/ConsoleMessageLogger.kt 0.00% 22 Missing ⚠️
...nt/android/features/call/impl/ui/CallScreenView.kt 28.57% 5 Missing ⚠️
...droid/features/call/impl/ui/ElementCallActivity.kt 0.00% 3 Missing ⚠️
...c/main/kotlin/io/element/android/x/di/AppModule.kt 0.00% 2 Missing ⚠️
...droid/features/call/impl/ui/CallScreenPresenter.kt 66.66% 1 Missing ⚠️
...eatures/call/impl/utils/WidgetMessageSerializer.kt 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5552      +/-   ##
===========================================
- Coverage    81.84%   81.84%   -0.01%     
===========================================
  Files         2371     2372       +1     
  Lines        67326    67337      +11     
  Branches      8201     8202       +1     
===========================================
+ Hits         55105    55109       +4     
- Misses        9174     9181       +7     
  Partials      3047     3047              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants