Skip to content

Conversation

@ganfra
Copy link
Member

@ganfra ganfra commented Nov 3, 2025

Content

Preliminary work for Space settings, ie create the screen and the navigation for it.
Make it available only when the subscreens are ready.

Motivation and context

Part of #5648

Screenshots / GIFs

Check screenshots.

Tests

Nothing to test for now.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ganfra ganfra added Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. PR-Wip For anything that isn't ready to ship and will be enabled at a later date labels Nov 3, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/U18piY

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 81.20805% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.73%. Comparing base (8de14a2) to head (8dec660).
⚠️ Report is 56 commits behind head on develop.

Files with missing lines Patch % Lines
...ures/space/impl/settings/SpaceSettingsPresenter.kt 0.00% 13 Missing ⚠️
.../features/space/impl/settings/SpaceSettingsView.kt 90.52% 0 Missing and 9 partials ⚠️
...ndroid/features/space/impl/leave/LeaveSpaceView.kt 33.33% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #5668    +/-   ##
=========================================
  Coverage    79.73%   79.73%            
=========================================
  Files         2420     2424     +4     
  Lines        65029    65178   +149     
  Branches      8296     8311    +15     
=========================================
+ Hits         51848    51969   +121     
- Misses       10209    10227    +18     
- Partials      2972     2982    +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ganfra ganfra marked this pull request as ready for review November 3, 2025 19:27
@ganfra ganfra requested a review from a team as a code owner November 3, 2025 19:27
@ganfra ganfra requested review from bmarty and removed request for a team November 3, 2025 19:27
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

private val leaveSpaceHandle = matrixClient.spaceService.getLeaveSpaceHandle(room.roomId)
private val presenter: LeaveSpacePresenter = presenterFactory.create(leaveSpaceHandle)

private val callback = plugins<Callback>().single()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extension, can be replaced by
private val callback: Callback = callback()

fun startLeaveSpaceFlow()
}

private val callback = plugins<Callback>().single()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private val callback: Callback = callback()

@ganfra ganfra enabled auto-merge November 5, 2025 14:43
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2025

@ganfra ganfra merged commit bd14e74 into develop Nov 5, 2025
29 of 30 checks passed
@ganfra ganfra deleted the feature/fga/space_settings branch November 5, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Wip For anything that isn't ready to ship and will be enabled at a later date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants