-
Notifications
You must be signed in to change notification settings - Fork 369
Space : prepare Space Settings screen #5668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # appnav/src/main/kotlin/io/element/android/appnav/room/RoomFlowNode.kt
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5668 +/- ##
=========================================
Coverage 79.73% 79.73%
=========================================
Files 2420 2424 +4
Lines 65029 65178 +149
Branches 8296 8311 +15
=========================================
+ Hits 51848 51969 +121
- Misses 10209 10227 +18
- Partials 2972 2982 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bmarty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
| private val leaveSpaceHandle = matrixClient.spaceService.getLeaveSpaceHandle(room.roomId) | ||
| private val presenter: LeaveSpacePresenter = presenterFactory.create(leaveSpaceHandle) | ||
|
|
||
| private val callback = plugins<Callback>().single() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an extension, can be replaced by
private val callback: Callback = callback()
| fun startLeaveSpaceFlow() | ||
| } | ||
|
|
||
| private val callback = plugins<Callback>().single() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private val callback: Callback = callback()
|



Content
Preliminary work for Space settings, ie create the screen and the navigation for it.
Make it available only when the subscreens are ready.
Motivation and context
Part of #5648
Screenshots / GIFs
Check screenshots.
Tests
Nothing to test for now.
Tested devices
Checklist