-
Notifications
You must be signed in to change notification settings - Fork 369
Always use the handleEvent(s) function the same way. #5672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5672 +/- ##
========================================
Coverage 79.73% 79.73%
========================================
Files 2420 2420
Lines 65029 65029
Branches 8296 8296
========================================
Hits 51848 51848
Misses 10209 10209
Partials 2972 2972 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This has the side effect of not displaying the actual error when something unexpected happens in the tests related to the state values, instead displaying an error saying it can't print the actual error because it doesn't know how to debug-print the state value because it doesn't have the kotlin reflection library. We could maybe add kotlin-reflect as a |
When we have such issue in the test, we now know that it's because there are unconsumed state(s) (some |
We do, but it's not the first time - and won't be the last - I've had to tell some contributor why that happened (ask @richvdh ). If we can fix it with adding the library just for the unit tests it seems like a good trade-off. |
jmartinesp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like just adding the lib doesn't fix the mentioned issue. It's ok then, let's just merge this and we can later iterate on it.



Just a small cleanup on our codebase.