Skip to content

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Nov 3, 2025

Just a small cleanup on our codebase.

@bmarty bmarty requested a review from a team as a code owner November 3, 2025 17:54
@bmarty bmarty requested review from jmartinesp and removed request for a team November 3, 2025 17:54
@bmarty bmarty added the PR-Build For changes related to build, tools, CI/CD label Nov 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/bGCKwT

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2025

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.73%. Comparing base (f1389cb) to head (fdd4e21).
⚠️ Report is 16 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5672   +/-   ##
========================================
  Coverage    79.73%   79.73%           
========================================
  Files         2420     2420           
  Lines        65029    65029           
  Branches      8296     8296           
========================================
  Hits         51848    51848           
  Misses       10209    10209           
  Partials      2972     2972           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmartinesp
Copy link
Member

This has the side effect of not displaying the actual error when something unexpected happens in the tests related to the state values, instead displaying an error saying it can't print the actual error because it doesn't know how to debug-print the state value because it doesn't have the kotlin reflection library.

We could maybe add kotlin-reflect as a testImplementation dependency, see if that fixes the issue.

@bmarty
Copy link
Member Author

bmarty commented Nov 4, 2025

This has the side effect of not displaying the actual error when something unexpected happens in the tests related to the state values, instead displaying an error saying it can't print the actual error because it doesn't know how to debug-print the state value because it doesn't have the kotlin reflection library.

When we have such issue in the test, we now know that it's because there are unconsumed state(s) (some awaitItem() are missing), so I think it's fine, do you agree?

@jmartinesp
Copy link
Member

This has the side effect of not displaying the actual error when something unexpected happens in the tests related to the state values, instead displaying an error saying it can't print the actual error because it doesn't know how to debug-print the state value because it doesn't have the kotlin reflection library.

When we have such issue in the test, we now know that it's because there are unconsumed state(s) (some awaitItem() are missing), so I think it's fine, do you agree?

We do, but it's not the first time - and won't be the last - I've had to tell some contributor why that happened (ask @richvdh ). If we can fix it with adding the library just for the unit tests it seems like a good trade-off.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like just adding the lib doesn't fix the mentioned issue. It's ok then, let's just merge this and we can later iterate on it.

@bmarty bmarty merged commit 2b08cb7 into develop Nov 4, 2025
36 of 37 checks passed
@bmarty bmarty deleted the feature/bma/handleEvents branch November 4, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Build For changes related to build, tools, CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants