Improve account provider selection during the login flow #5692

bmarty · 2025-11-06T14:39:59Z

Content

Ensure that the user can always get an explicit error up on what has been entered. Either there is no homeserver at the provided url, either the homeserver does not support login password not Oidc flow.

Motivation and context

Give explicit error to users.
Help #4556 and #5627

Screenshots / GIFs

Tests

Start the app (no existing sessions)
Click on "Sign in manually"
Click on "Change account provider"
Click on "Other"
In the text field, enter an invalid homewerver url (for instance "invalid.com")
Observe that "invalid.com" appears as a candidate. This is new. Previously https://invalid.com had to be entered for the candidate to appear.

Click on the candidate
An error is displayed

Close the dialog
Enter the url of a homeserver that does not support OIDC nor password, for instance matrix.debian.social.
Observe that "matrix.debian.social" appears as a candidate
click on the candidate
Observe the specific error

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes have been tested on an Android device or Android emulator with API 24
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request title will be used in the release note, it clearly define what will change for the user
Pull request includes screenshots or videos if containing UI changes
You've made a self review of your PR

…eFlow<MatrixHomeServerDetails?>`. The MatrixHomeServerDetails are now return by `setHomeserver`

…y local `fun aMatrixHomeServerDetails()`.

…he appropriate error (parity with iOS)

…ror if they continue

github-actions · 2025-11-06T14:46:16Z

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/4RqtE6

codecov · 2025-11-06T15:30:10Z

Codecov Report

❌ Patch coverage is 73.61111% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.64%. Comparing base (c1da482) to head (fe2a317).
⚠️ Report is 49 commits behind head on develop.

Files with missing lines	Patch %	Lines
...atures/login/impl/changeserver/ChangeServerView.kt	38.46%	6 Missing and 2 partials ⚠️
...oid/features/login/impl/error/ChangeServerError.kt	33.33%	6 Missing and 2 partials ⚠️
...android/features/login/impl/login/LoginModeView.kt	90.00%	0 Missing and 1 partial ⚠️
...features/login/impl/resolver/HomeserverResolver.kt	50.00%	0 Missing and 1 partial ⚠️
...atrix/impl/auth/RustMatrixAuthenticationService.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5692      +/-   ##
===========================================
- Coverage    79.65%   79.64%   -0.01%     
===========================================
  Files         2427     2428       +1     
  Lines        65212    65242      +30     
  Branches      8318     8328      +10     
===========================================
+ Hits         51945    51963      +18     
- Misses       10291    10300       +9     
- Partials      2976     2979       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ganfra · 2025-11-06T17:46:06Z

...src/main/kotlin/io/element/android/features/login/impl/changeserver/ChangeServerPresenter.kt

-                accountProviderDataSource.userSelection(data)
-            }.getOrThrow()
+            val details = authenticationService.setHomeserver(data.url).getOrThrow()
+            if (details.supportsOidcLogin.not() && details.supportsPasswordLogin.not()) {


I'm not a big fan of not...

You just used it in your comment :).
I have updated the code.

ganfra · 2025-11-06T17:47:29Z

...src/main/kotlin/io/element/android/features/login/impl/changeserver/ChangeServerPresenter.kt

+            val details = authenticationService.setHomeserver(data.url).getOrThrow()
+            if (details.supportsOidcLogin.not() && details.supportsPasswordLogin.not()) {
+                // Unsupported homeserver
+                throw ChangeServerError.Error(


I'd remove this Error which is a bit confusing, and create individual error for all the defined errors + one Unknown case for the default behavior

I have done that and improve the error mapping.

sonarqubecloud · 2025-11-07T13:23:06Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bmarty added 9 commits November 6, 2025 12:22

MatrixAuthenticationService: remove `fun getHomeserverDetails(): Stat…

0be6d13

…eFlow<MatrixHomeServerDetails?>`. The MatrixHomeServerDetails are now return by `setHomeserver`

Do not override the value of url returned by the SDK

cee6475

Fix test

4cc5cf0

MatrixHomeServerDetails does not need to be Parcelable

6617db0

Remove A_HOMESERVER and A_HOMESERVER_OIDC from TestData and replace b…

8fa2c6c

…y local `fun aMatrixHomeServerDetails()`.

Ensure user cannot select unsupported homeserver. In this case show t…

e3ed75d

…he appropriate error (parity with iOS)

Always let the user try what they have entered, to get an explicit er…

a995850

…ror if they continue

Small cleanup

fd0ef1a

Use presenter test extension

5b472fd

bmarty added PR-Change For updates to an existing feature Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels Nov 6, 2025

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 6, 2025

Update screenshots

0657a20

bmarty marked this pull request as ready for review November 6, 2025 15:20

bmarty requested a review from a team as a code owner November 6, 2025 15:20

bmarty requested review from ganfra and removed request for a team November 6, 2025 15:20

manuroe mentioned this pull request Nov 6, 2025

"we couldn't reach this homeserver" is incredibly vague and hard to debug #4556

Open

ganfra reviewed Nov 6, 2025

View reviewed changes

bmarty added 4 commits November 7, 2025 09:42

Create specific errors for Invalid or Unsupporte homeserver.

b61ce1b

Improve error mapping

e12726f

Improve error mapping

98792c9

Avoid usage of not() and add unit tests.

70e3e76

bmarty requested a review from ganfra November 7, 2025 09:19

Use isNull()

cc01e19

bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 7, 2025

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 7, 2025

Update screenshots

3fd961c

Oups, thanks unit tests!

fe2a317

ganfra approved these changes Nov 7, 2025

View reviewed changes

bmarty merged commit 77bc9b8 into develop Nov 7, 2025
29 of 32 checks passed

bmarty deleted the feature/bma/loginFlow branch November 7, 2025 15:48

bmarty mentioned this pull request Nov 10, 2025

tells people to install the sliding sync proxy #4500

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve account provider selection during the login flow #5692

Improve account provider selection during the login flow #5692

Uh oh!

bmarty commented Nov 6, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 6, 2025 •

edited

Loading

Uh oh!

codecov bot commented Nov 6, 2025 •

edited

Loading

Uh oh!

ganfra Nov 6, 2025

Uh oh!

bmarty Nov 7, 2025

Uh oh!

ganfra Nov 6, 2025

Uh oh!

bmarty Nov 7, 2025

Uh oh!

sonarqubecloud bot commented Nov 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Improve account provider selection during the login flow #5692

Improve account provider selection during the login flow #5692

Uh oh!

Conversation

bmarty commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

Uh oh!

github-actions bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ganfra Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

bmarty Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

ganfra Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

bmarty Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Nov 7, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bmarty commented Nov 6, 2025 •

edited

Loading

github-actions bot commented Nov 6, 2025 •

edited

Loading

codecov bot commented Nov 6, 2025 •

edited

Loading