Skip to content

Fix: use correct parameter when calling get_local_current_membership_for_user_in_room #19353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anoadragon453 merged 3 commits into from
Jan 7, 2026
+2 −1
Merged

Fix: use correct parameter when calling get_local_current_membership_for_user_in_room #19353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a40e6cf
Fix: use correct parameter when calling get_local_current_membership_…
lukastautz Jan 7, 2026
b4d34ed
Add changelog for PR 19353
lukastautz Jan 7, 2026
97aadfb
Add time of bug introduction and more details to newsfile
anoadragon453 Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/19353.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug introduced in 1.61.0 where a user's membership in a room was accidentally ignored when considering access to historical state events in rooms with the "shared" history visibility. Contributed by Lukas Tautz.
2 changes: 1 addition & 1 deletion synapse/handlers/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ async def _user_can_see_state_at_event(
current_membership,
_,
) = await self.store.get_local_current_membership_for_user_in_room(
user_id, event_id
user_id, room_id
Copy link
Contributor

@MadLittleMods MadLittleMods Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably catch this better if we enforced keyword args on get_local_current_membership_for_user_in_room(...):

    async def get_local_current_membership_for_user_in_room(
        self, *, user_id: str, room_id: str
    ) -> tuple[str | None, str | None]:

In this usage, we would see room_id=event_id which won't be picked up by the linter but is more obvious to the eyes as a mistake.

Additionally, these are both str args which could be confused on order.

Copy link
Member

@anoadragon453 anoadragon453 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point for making wider use of kwargs!

)
return current_membership == Membership.JOIN

Expand Down