Skip to content

Warn about skipping reactor metrics when using unknown reactor type #19383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MadLittleMods merged 3 commits into from
Jan 15, 2026
+8 −2
Merged

Warn about skipping reactor metrics when using unknown reactor type #19383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
923486a
Warn about skipping `ReactorLastSeenMetric` with unknown reactor type
MadLittleMods Jan 15, 2026
0cf610f
Be generic about "reactor metrics"
MadLittleMods Jan 15, 2026
fe3d3e7
Add changelog
MadLittleMods Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/19383.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Warn about skipping reactor metrics when using unknown reactor type.
9 changes: 7 additions & 2 deletions synapse/metrics/_reactor_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,17 @@ def collect(self) -> Iterable[Metric]:
else:
# E.g. this does not support the (Windows-only) ProactorEventLoop.
logger.warning(
"Skipping configuring ReactorLastSeenMetric: unexpected asyncio loop selector: %r via %r",
"Skipping configuring reactor metrics: unexpected asyncio loop selector: %r via %r",
Copy link
Contributor Author

@MadLittleMods MadLittleMods Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this generic as "reactor metrics" instead of ReactorLastSeenMetric because we're actually configuring python_twisted_reactor_last_seen AND python_twisted_reactor_tick_time here

Copy link
Member

@devonh devonh Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.

selector,
asyncio_loop,
)
else:
logger.warning(
"Skipping configuring reactor metrics: unexpected reactor type: %r",
reactor,
)
Comment on lines +165 to +169
Copy link
Contributor Author

@MadLittleMods MadLittleMods Jan 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the new warning when we see a new unexpected reactor type.

In my case, we we're running up against ProxiedReactor which isn't handled yet.

Copy link
Contributor

@clokep clokep Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(o_O) What's a ProxiedReactor?! https://github.com/search?q=repo%3Atwisted%2Ftwisted%20ProxiedReactor&type=code

Copy link
Contributor Author

@MadLittleMods MadLittleMods Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More investigation in #19385

This PR was mainly just to give better feedback regardless of the reactor.

except Exception as e:
logger.warning("Configuring ReactorLastSeenMetric failed: %r", e)
logger.warning("Configuring reactor metrics failed: %r", e)


if wrapper:
Expand Down