Improve JSON and Jason support

[warmwaffles]

Elixir version

1.18

Database and Version

all

Ecto Versions

any

Database Adapter and Versions (postgrex, myxql, etc)

postgrex, myxql, exqlite

Current behavior

When running Elixir 1.18 and setting the json adapter to JSON, we encounter issues where encode/1 is not defined, but encode!/1 is. This issue was started here elixir-sqlite/ecto_sqlite3#159

Expected behavior

I should be able to flip between Jason and JSON to support Elixir 1.17 and 1.18.

A "quick-ish" fix is to wrap the encode!/1 from both Jason and JSON with a try rescue to keep the {:ok, term} | {:error, term} typespec behaviour.

[wojtekmach]

Database Adapter and Versions (postgrex, myxql, etc)

postgrex, myxql, exqlite

you mentioned all adapters, does the problem appear in all of them or just exqlite?

[josevalim]

We can just do {:ok, JSON.encode!(...)} I believe. Even Jason.encode fails in a bunch of different situations today and the situations where it doesn't, I think the users are unlikely to run into

[warmwaffles]

Right.

I also see this unit https://github.com/elixir-ecto/ecto/blob/master/lib/ecto/json.ex, may need to implement the JSON.Encoder and such here as well.

[TylerWitt]

I made a PR that handles some of the needed changes, but am I correct in thinking that the encode vs encode! changes also discussed here need to happen in the adapters themselves?

[josevalim]

I made a PR that handles some of the needed changes, but am I correct in thinking that the encode vs encode! changes also discussed here need to happen in the adapters themselves?

Yes, they must!

[halfdan]

Am I correct in assuming that there are no further changes needed in ecto itself?

I'm interested in helping getting this issue resolved so any pointers would be great.

[josevalim]

Correct. It seems everything has been done on the Ecto side, thanks!