Skip to content

Fix keymap, command name#19

Merged
bdarcus merged 4 commits intoemacs-citar:mainfrom
Yevgnen:main
Mar 9, 2021
Merged

Fix keymap, command name#19
bdarcus merged 4 commits intoemacs-citar:mainfrom
Yevgnen:main

Conversation

@Yevgnen
Copy link
Contributor

@Yevgnen Yevgnen commented Mar 8, 2021

No description provided.

@bdarcus
Copy link
Contributor

bdarcus commented Mar 8, 2021

Thanks for this @Yevgnen!

Can you please provide a description to your OP explaining what you did and why?

I see from your changes there's a mistake that you fixed (the "PDF" one), and maybe some differences of opinion on command names, which we can discuss.

But I also forgot to update the keymap earlier, so I'm not sure if your PR is only aligning keymap and function name, or objecting to the names themselves.

If the former, you can just fix the keymap to point to the correct commands.

EDIT: also, see #12 for context.

@Yevgnen
Copy link
Contributor Author

Yevgnen commented Mar 9, 2021

Hi, sorry I didn't notice #12 . I tried to fix this only since I found the keymap was broken when dealing with the bibtex completion. And my original fix tried to follow the original bibtex-completion-*names.

Copy link
Contributor

@bdarcus bdarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correction of "PDF" to "pdf" was correct. I fixed that on the keymap; can you update the function name to match (not an easy way for me to do that with the web UI)?

@Yevgnen
Copy link
Contributor Author

Yevgnen commented Mar 9, 2021

@bdarcus Done!

@bdarcus bdarcus merged commit f25eb67 into emacs-citar:main Mar 9, 2021
@bdarcus
Copy link
Contributor

bdarcus commented Mar 9, 2021

Merged; thanks much!

@bdarcus
Copy link
Contributor

bdarcus commented Mar 9, 2021

PS - if you have time and interest, @Yevgnen, I could use help fixing #18. There's some subtle thing wrong with it ATM.

@bdarcus bdarcus changed the title Fixed API names Fix keymap, command name Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants