Fix up Info-mode

[MaxCan-Code]

No description provided.

[KSSysLab]

I'm curious about why digit-argument bindings are not working out of box.

When pressing 0, Emacs will try to find the keymap in this order. It can be confirmed that emulation-mode-map-alists will be used. And the first element is evil-mode-map-alist. Let me dig deeper.

;; eval under evil-normal-state
(mapcar 'car evil-mode-map-alist)
;;=> (t evil-normal-state-local-minor-mode outline-minor-mode evil-collection-unimpaired-mode t evil-normal-state-minor-mode t evil-motion-state-local-minor-mode visual-line-mode evil-collection-unimpaired-mode evil-motion-state-minor-mode)

Found that evil-motion-state-minor-mode is in this alist. And

;; eval under evil-normal-state
(describe-keymap (alist-get 'evil-motion-state-minor-mode evil-mode-map-alist))

;; ...
;; ,               evil-repeat-find-char-reverse
;; -               evil-previous-line-first-non-blank
;; /               evil-search-forward
;; 0               evil-digit-argument-or-evil-beginning-of-line
;; 1 .. 9          digit-argument
;; :               evil-ex
;; ;               evil-repeat-find-char
;; ?               evil-search-backward
;; B               evil-backward-WORD-begin
;; E               evil-forward-WORD-end
;; ...

[1, 9] have already bound to digit-argument.

So when I press 0 in evil normal state, Emacs should find digit-argument. However, Emacs runs Info-nth-menu-item which is bound in Info-mode-map. Note that Info-mode-map is the 7th candidate when lookup keys.

[KSSysLab]

evil-overriding-maps is a variable defined in ‘evil-vars.el’.

Its value is shown below.

  You can customize this variable.

Keymaps that should override Evil maps.
Entries have the form (MAP-VAR . STATE), where MAP-VAR is
a keymap variable and STATE is the state whose bindings
should be overridden. If STATE is nil, all states are
overridden.

Value:
((Buffer-menu-mode-map)
 (color-theme-mode-map)
 (comint-mode-map)
 (compilation-mode-map)
 (grep-mode-map)
 (dictionary-mode-map)
 (ert-results-mode-map . motion)
 (Info-mode-map . motion)
 (speedbar-key-map)
 (speedbar-file-key-map)
 (speedbar-buffers-key-map))

[back]

Info-mdoe-map is in evil-overriding-maps, so that the commands bound in evil motion state map will have no effects.

[MaxCan-Code]

Info-nth-menu-item still overrides digit-argument after I delete Info-mode-map from evil-overriding-maps:

evil-collection/modes/info/evil-collection-info.el

Lines 37 to 41 in d8d8b13

	(defun evil-collection-info-setup ()
	"Set up `evil' bindings for `info-mode'."
	(evil-collection-set-readonly-bindings 'Info-mode-map)
	(evil-set-initial-state 'Info-mode 'normal)
	(evil-collection-define-key 'normal 'Info-mode-map

(defun evil-collection-info-setup ()
  "Set up `evil' bindings for `info-mode'."
  (evil-collection-set-readonly-bindings 'Info-mode-map)
+ (assoc-delete-all 'Info-mode-map evil-overriding-maps)
  (evil-set-initial-state 'Info-mode 'normal)
  (evil-collection-define-key 'normal 'Info-mode-map

Let me know if there's a better way to do this

[condy0919]

If you're a use-package user, use :custom to customize the evil-overriding-maps.

[condy0919]

FYI, I propose to change the default value of evil-overriding-maps emacs-evil/evil#1488

[MaxCan-Code]

When that change comes through, I can remove the manual evil overrides in

evil-collection/modes/info/evil-collection-info.el

Lines 96 to 107 in d8d8b13

	;; goto
	"gd" 'Info-goto-node ; TODO: "gd" does not match the rationale of "go to definition". Change?
	"gm" 'Info-menu
	"m" 'evil-set-marker ; Else this would be `Info-menu'.
	"gt" 'Info-top-node
	"t" 'evil-find-char-to ; Else this would be `Info-top-node'.
	"gT" 'Info-toc
	"T" 'evil-find-char-to-backward ; Else this would be `Info-toc'.
	"gf" 'Info-follow-reference
	"f" 'evil-find-char ; Else this would be `Info-follow-reference'.
	;; TODO: "[" and "]" are Emacs default for fine-grained browsing.

and

evil-collection/modes/info/evil-collection-info.el

Lines 114 to 131 in d8d8b13

	"g?" 'Info-summary
	"?" evil-collection-evil-search-backward) ; Else this would be `Info-summary'.
	(evil-collection-define-key 'visual 'Info-mode-map
	"l" 'evil-forward-char
	"h" 'evil-backward-char
	"w" 'evil-forward-word-begin
	"b" 'evil-backward-word-begin
	"e" 'evil-forward-word-end
	"f" 'evil-find-char
	"t" 'evil-find-char-to
	"T" 'evil-find-char-to-backward
	"0" 'evil-digit-argument-or-evil-beginning-of-line
	"gg" 'evil-goto-first-line)

[condy0919]

The PR is merged.

[MaxCan-Code]

The mappings are fixed

[condy0919]

Thanks