syntax error in rustic-cargo-add with prefix argument#10
Merged
CeleritasCelery merged 1 commit intomainfrom May 19, 2024
Merged
syntax error in rustic-cargo-add with prefix argument#10CeleritasCelery merged 1 commit intomainfrom
CeleritasCelery merged 1 commit intomainfrom
Conversation
Original description by @sigvei in brotzeit/rustic#536: rustic-cargo-add with a prefix command called read-from-minibuffer with erroneous arguments. The current master produces this error message: funcall-interactively: Wrong type argument: keymapp, " add " This is due to the line (read-from-minibuffer "Cargo add command: " (rustic-cargo-bin) " add "), which makes " add " a third argument to read-from-minibuffer. I guess it's suppose to just be concated with rustic-cargo-bin. This commit implements that and also DRY's the code by storing the base command in a let binding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original description by @sigvei in brotzeit/rustic#536:
rustic-cargo-add with a prefix command called read-from-minibuffer with erroneous arguments.
The current master produces this error message:
funcall-interactively: Wrong type argument: keymapp, " add "
This is due to the line (read-from-minibuffer "Cargo add command: " (rustic-cargo-bin) " add "), which makes " add " a third argument to read-from-minibuffer. I guess it's suppose to just be concated with rustic-cargo-bin.
This commit implements that and also DRY's the code by storing the base command in a let binding.