Fix regex pattern for tagged rust warnings in compilation output#122
Merged
CeleritasCelery merged 1 commit intoemacs-rustic:mainfrom Feb 12, 2026
Merged
Fix regex pattern for tagged rust warnings in compilation output#122CeleritasCelery merged 1 commit intoemacs-rustic:mainfrom
CeleritasCelery merged 1 commit intoemacs-rustic:mainfrom
Conversation
Rust now emits warnings with optional tags (e.g., "warning[E0133]:"). Update the warning regex pattern to match the approach already used for error patterns, which handle the same tagged format. The pattern now accepts optional content between 'warning' and the colon, matching the existing error pattern that handles 'error[^:]*:'. Fixes: emacs-rustic#121 Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Contributor
Author
|
I think, the CI errors are caused by something else (missing metadata required by recent eask?) |
Contributor
|
yes, I just ran the CI and it is failing. It has not been run in a while so something is broken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust now emits warnings with optional tags (e.g., "warning[E0133]:"). Update the warning regex pattern to match the approach already used for error patterns, which handle the same tagged format.
The pattern now accepts optional content between 'warning' and the colon, matching the existing error pattern that handles 'error[^:]*:'.
Fixes: #121