Skip to content

Drop support for Node 10 and upgrade deps#690

Merged
step2yeung merged 3 commits intoember-cli:masterfrom
nlfurniss:update-deps
Aug 9, 2021
Merged

Drop support for Node 10 and upgrade deps#690
step2yeung merged 3 commits intoember-cli:masterfrom
nlfurniss:update-deps

Conversation

@nlfurniss
Copy link
Contributor

@nlfurniss nlfurniss commented Jun 9, 2021

This cleans up build and test deprecation warnings

  • Drops Node 10 support (wasn't being tested in CI anyway 😬 )
  • Upgrades ember-cli-addon-docs (didnt play nicely with embroider tests)
  • Removed as no longer needed: ember-cli-htmlbars-inline-precompile, ember-cli-shims

@rwjblue
Copy link
Member

rwjblue commented Jun 9, 2021

@nlfurniss - Should be good with a rebase (since you fixed the Embroider failures), I think.

@nlfurniss
Copy link
Contributor Author

@nlfurniss - Should be good with a rebase (since you fixed the Embroider failures), I think.

Sadly no. Will debug locally

@step2yeung step2yeung merged commit d387848 into ember-cli:master Aug 9, 2021
@nlfurniss nlfurniss deleted the update-deps branch August 9, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants