#354 Fix onClicked warning if @type is "submit"#526
Merged
mansona merged 1 commit intoember-learn:masterfrom Mar 13, 2026
Merged
#354 Fix onClicked warning if @type is "submit"#526mansona merged 1 commit intoember-learn:masterfrom
mansona merged 1 commit intoember-learn:masterfrom
Conversation
❌ Deploy Preview for ember-styleguide failed.
|
tcjr
changed the title
MinThaMie
approved these changes
May 5, 2025
mansona
force-pushed
the
fix-onclick-warning
branch
from
04faf1e to
334d648
Compare
✅ Deploy Preview for ember-styleguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mansona
force-pushed
the
fix-onclick-warning
branch
from
334d648 to
7918657
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is perfectly valid for submit buttons in a form:
This PR removes the console warning (and stack trace) when a submit button has no
onClickedattribute.You can see it in the wild by looking at the console output for the component page for EsButton.
Fixes #354